Skip to content

docs: Document workaround to disable SNI checks #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 8, 2025
Merged

docs: Document workaround to disable SNI checks #834

merged 12 commits into from
Oct 8, 2025
+40 −4

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Aug 13, 2025 •
edited by NickLarsenNZ
Loading

Description

Important

This should only be merged once stackabletech/docker-images#1225 is merged

Document workaround to disable SNI checks.
I took the opportunity to rewrite the entire FAQ entry.

@lfrancke lfrancke enabled auto-merge August 13, 2025 21:21
@lfrancke lfrancke mentioned this pull request Aug 13, 2025
Open
3 tasks
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Aug 13, 2025
@lfrancke lfrancke self-assigned this Aug 13, 2025
@lfrancke lfrancke disabled auto-merge August 13, 2025 21:26
sbernauer
sbernauer previously approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should hold of merging until stackabletech/docker-images#1225 is merged.

Can you please also add a docs: prefix to the PR title? :)
If you have the time I would also be happy about a changelog entry that you can now disable the check via configOverrides (yeah, this is a docker-image thing, but users are not going to read docker-images changelog)

@lfrancke lfrancke changed the title Document workaround to disable SNI checks docs: Document workaround to disable SNI checks Aug 14, 2025
@lfrancke
Copy link
Member Author

I thought about that and wasn't sure.
We can also consider whether we want to expose this as a CRD flag.....let's talk about it at the daily and decide how to proceed.

sbernauer
sbernauer reviewed Aug 14, 2025
View reviewed changes
@lfrancke lfrancke requested a review from sbernauer August 14, 2025 10:28
sbernauer
sbernauer previously approved these changes Aug 14, 2025
View reviewed changes
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 14, 2025
@sbernauer sbernauer assigned NickLarsenNZ and xeniape and unassigned lfrancke Aug 18, 2025
xeniape
xeniape reviewed Aug 18, 2025
View reviewed changes
sbernauer
sbernauer previously approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, thanks @xeniape for the suggestions!

NickLarsenNZ
NickLarsenNZ reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and suggestions.

Hopefully we can remove the SNI workarounds soon.

@NickLarsenNZ
Copy link
Member

Not sure who is supposed to resolve or reply to my comments.

@lfrancke lfrancke assigned lfrancke and unassigned NickLarsenNZ and xeniape Sep 3, 2025
NickLarsenNZ
NickLarsenNZ reviewed Sep 25, 2025
View reviewed changes
@lfrancke lfrancke requested a review from NickLarsenNZ October 2, 2025 14:18
@lfrancke
Copy link
Member Author

lfrancke commented Oct 2, 2025

I have decided to go with my original proposal for the two comments you disagree with, incorporated another and believe you're wrong about the last.
But if things go the way they usually go I end up being the one that was wrong after all. Let's see :)

@lfrancke lfrancke requested a review from xeniape October 6, 2025 11:29
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, ship it :D

@lfrancke
Copy link
Member Author

lfrancke commented Oct 8, 2025

Now it has conflicts and I can't merge it from the phone :) I'll try to fix that in the next few days.

@NickLarsenNZ

This comment was marked as outdated.

Sign in to view
@NickLarsenNZ

This comment was marked as outdated.

Sign in to view
@razvan
Copy link
Member

razvan commented Oct 8, 2025

I needed this today #shipit #nopressure

@sbernauer
Copy link
Member

(or turn the SNI checks off by default) 🙊 😇

@lfrancke
Copy link
Member Author

lfrancke commented Oct 8, 2025

I think it's ready to be merged if Nick fixed the conflict? I think you should be able to approve it

@lfrancke lfrancke enabled auto-merge October 8, 2025 13:58
@lfrancke lfrancke added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit 06f365c Oct 8, 2025
16 of 17 checks passed
@lfrancke lfrancke deleted the feat/SNI branch October 8, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeniape xeniape xeniape approved these changes

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@sbernauer sbernauer sbernauer left review comments

Assignees

@lfrancke lfrancke

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfrancke @NickLarsenNZ @razvan @sbernauer @xeniape